fix: avoid null exception when received body is empty but recorded body isn't #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thanks for reaching out and for the kind words! Good catch on this, we'll get it patched ASAP. |
nwithan8
approved these changes
Feb 2, 2024
nwithan8
force-pushed
the
fix-null-ref-exception-on-empty-body
branch
from
ae7d981
to
821c898
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly, thank you so much for creating and maintaining this library 🙏
I've been a VCR user in ruby, and have been looking for a comparable library for c# for a while.
Thank you for your hard work!
I encountered the issue below when using VCR in conjunction with the
refitlibrary (https://github.com/reactiveui/refit).Refit would automatically assign an empty body to requests, unless defined otherwise.
I would then get null ref exception when trying to record a new request onto an existing cassette.
Description
Closes #58
Testing
Unit test added
Pull Request Type
Please select the option(s) that are relevant to this PR.